-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Configs #218
Merged
Merged
Refactor Configs #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
mrwyattii
commented
Aug 8, 2023
jeffra
approved these changes
Sep 20, 2023
tohtana
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great effort! I've noticed that the areas I had concerns about have been improved. This will make future development much more pleasant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better support multi-model deployments and associated features from #208 we have identified some key ways in which the configs can be refactored. This will be the first of 2-3 PRs that does some refactor work and implements smaller segments of the work done in #208 to make review and merging easier.
@TosinSeg
Work done in this PR:
MIIConfig
andDeploymentConfig
. This is in anticipation of having multi-model deployments where we will be passing in multipleDeploymentConfig
objectsInferenceConfig
rather than recreating that config inload_models.py
(see comments I left on the code changes)mii_config
object as it contains everything we want. This massively simplifies the score template and server classyapf
for formatting, but this allows mixed'
and"
- I don't think we need to use one or the other, but being consistent is good. Appliedblack
and thenyapf
to get some nicer formatting (especially on the long assert lines)black
? @jeffraI left lots of comments about changes I felt unsure about or where I could use some feedback, however the PR is mostly ready to merge. We could always handle minor cleanup and changes in future PRs that implement the rest of #208