Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Cython static compiler dependency #783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dan-developer
Copy link

@dan-developer dan-developer commented Aug 29, 2022

Pull request title

  • I read contributing guideline
  • I didn't find a similar pull request already open.
  • x ] My PR is related to Spleeter only, not a derivative product (such as Webapplication, or GUI provided by others)

Description

A few sentences describing the overall goals of the pull request's commits.

How this patch was tested

You tested it, right?

  • I implemented unit test whicn ran successfully using poetry run pytest tests/
  • Code has been formatted using poetry run black spleeter
  • Imports has been formatted using `poetry run isort spleeter``

Documentation link and external references

Please provide any info that may help us better understand your code.

@mmoussallam
Copy link
Collaborator

Hello @dan-developer

In my experience this dependency is not needed to install/run spleeter. Did you encounter an issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants