-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OneKey wallet into Deezy #324
Conversation
✅ Deploy Preview for deezy-place ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The concept is clear, but I don't think this functionally works, and actually prompts the unisat wallet instead
Is Onekey compatible with WebLN or the web3/Metamask standard? What's the easiest way to prompt the extension?
Trying to figure out if this would be another WebLN provider (similar to Alby) or a Web3 provider, which would basically be a copy of the requirements for something like Generative.xyz
We'll need to create a follow up PR on nosft-core as well https://github.com/deezy-inc/nosft-core/blob/main/src/app/wallet.ts#L16 if Onekey is a Metamask provider, it shouldn't be too difficult, and just need to make sure the onekey ethereumProvider is selected
image: "/images/logo/onekey.png", | ||
provider: "unisat", | ||
onClick: () => { | ||
onConnect("unisat.io", callback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to be a new identifier
@habibitcoin Thanks for your reply and suggestions. For example, the OneKey plug-in will inject
And the contents provided by Since the implementation of onekey's internal btc provider is exactly the same as unisat, according to your code, here we want to set the domain to Or we just set
and you will update the code in Which way do you think is better? |
@weatherstar let me know what you think of this approach: #326 I think it accomplishes the same goal, and also encourages usage of the .btc provider as opposed to the .ethereum provider |
No description provided.