fix @mjnagel feedback

defenseunicorns · Aug 2, 2024 · 575a585 · 575a585
1 parent 0de030b
commit 575a585
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/pepr/operator/crd/validators/package-validator.ts b/src/pepr/operator/crd/validators/package-validator.ts
@@ -92,6 +92,15 @@ export async function validator(req: PeprValidateRequest<UDSPackage>) {
         `The client ID "${client.clientId}" uses an invalid secret name ${client.secretName}`,
       );
     }
+    // If standardFlowEnabled is undefined (defaults to `true`) or explicitly true and there are no redirectUris set, deny the req
+    if (
+      (client.standardFlowEnabled === undefined || client.standardFlowEnabled) &&
+      !client.redirectUris
+    ) {
+      return req.Deny(
+        `The client ID "${client.clientId}" must specify redirectUris if standardFlowEnabled is turned on`,
+      );
+    }
   }
 
   return req.Approve();