Skip to content

Commit

Permalink
chore: remove loki peerauth exception (#1106)
Browse files Browse the repository at this point in the history
## Description

Upstream [grafana
docs](https://grafana.com/docs/loki/latest/setup/install/istio/) do not
indicate that this is necessary, likely it was used in the past when
services did not have the correct appProtocol. This may be causing
issues with our Loki clustering, but overall removing it improves our
security posture.

I also removed the action used during our cutover from promtail ->
vector.

## Related Issue

N/A

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

Recommend deploying Loki with an install and upgrade and validating
functionality:
```console
# Deploy slim-dev from last release
uds deploy oci://ghcr.io/defenseunicorns/packages/uds/bundles/k3d-core-slim-dev:0.32.1 --confirm
# (optional) Deploy monitoring layer for visualizing/querying loki easier
uds zarf p deploy oci://ghcr.io/defenseunicorns/packages/uds/core-monitoring:0.32.1-upstream --confirm
# (for testing upgrade) Deploy logging layer from last release
uds zarf p deploy oci://ghcr.io/defenseunicorns/packages/uds/core-logging:0.32.1-upstream --confirm
# Deploy logging from this branch (this includes an upgrade to the Loki version from main)
uds run test:single-layer --set layer=logging
# (optional) run the e2e tests for grafana which test the loki datasource
uds run -f src/grafana/tasks.yaml e2e-test --set FULL_CORE=true
```

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
  • Loading branch information
mjnagel authored Dec 10, 2024
1 parent 7370ab1 commit f87a96d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.

This file was deleted.

6 changes: 0 additions & 6 deletions src/vector/common/zarf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ components:
- ../values/values.yaml
actions:
onDeploy:
before:
- description: Remove Promtail Components if necessary
mute: true
cmd: |
./zarf package remove core --components promtail --confirm || true # Ensure this doesn't error on installs and upgrades when Promtail no longer exists
./zarf tools kubectl delete ns promtail || true # Ensure this doesn't error on installs and upgrades when Promtail no longer exists
after:
- description: Validate Vector Package
maxTotalSeconds: 300
Expand Down

0 comments on commit f87a96d

Please sign in to comment.