-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add generated target for all node IPs #1119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
changed the title
fix: Add generated target for all node IPs
fix: add generated target for all node IPs
Dec 12, 2024
mjnagel
reviewed
Dec 13, 2024
docs/reference/configuration/custom-resources/exemptions-v1alpha1-cr.md
Outdated
Show resolved
Hide resolved
5 tasks
mjnagel
added a commit
that referenced
this pull request
Dec 13, 2024
## Description The generated docs were moved, but it seems the script to generate them was not updated to reflect the new location. This PR fixes that. ## Related Issue Relates to #1119 because at the moment it has docs that shouldn't be generated in it. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [ ] ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed Signed-off-by: catsby <[email protected]> Co-authored-by: Micah Nagel <[email protected]>
- Update src/pepr/operator/controllers/network/generators/kubeNodes.ts - chipping away at tests - wrap fetchKubernetesNodes in a retry - refactor updateKubeNodes and such to reduce duplication Signed-off-by: catsby <[email protected]>
Signed-off-by: catsby <[email protected]>
Signed-off-by: catsby <[email protected]>
Signed-off-by: catsby <[email protected]>
catsby
force-pushed
the
970-all-nodes
branch
from
December 18, 2024 20:23
444bab8
to
1783349
Compare
Rebased with main, and I think I've addressed all the feedback |
mjnagel
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few follow-on comments here, the code logic looks good at this point though (comments are on comments/docs). I'll deploy and validate this resolves the prometheus error, wanted to post these comments first though.
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
Signed-off-by: catsby <[email protected]>
mjnagel
reviewed
Dec 19, 2024
…tpol modifications Signed-off-by: catsby <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
mjnagel
previously approved these changes
Dec 19, 2024
mjnagel
reviewed
Dec 20, 2024
mjnagel
reviewed
Dec 20, 2024
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
mjnagel
approved these changes
Dec 20, 2024
mjnagel
pushed a commit
that referenced
this pull request
Dec 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.33.1](v0.33.0...v0.33.1) (2024-12-20) ### Bug Fixes * add generated target for all node IPs ([#1119](#1119)) ([033338b](033338b)) ### Miscellaneous * add action to check readiness on renovate PRs before running CI ([#1144](#1144)) ([83d81c6](83d81c6)) * **deps:** update codeql action to v3.28.0 ([#1146](#1146)) ([fe9bccf](fe9bccf)) * **deps:** update k8s-sidecar to v1.28.4 ([#1132](#1132)) ([b4f15ff](b4f15ff)) * **deps:** update loki ([#1134](#1134)) ([56d0e39](56d0e39)) * **deps:** update prometheus-stack (prometheus 3.0.1, operator 0.79.2) ([#949](#949)) ([5a35fc6](5a35fc6)) * **deps:** update support-deps ([#1131](#1131)) ([4853969](4853969)) * **deps:** update support-deps ([#1138](#1138)) ([2764d03](2764d03)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new generator / target called
KubeNodes
that contains the internal IP addresses of nodes in the cluster.NOTE:
I have no idea (yet) wher theThey appear to be missing ondocs/reference/
file changes came from.main
.Related Issue
Relates to #970 .
Steps to Validate
include steps to verify 970 gets fixed.Type of change
Steps to Validate
Setup and verify behavior of the target
Create a k3d cluster named
uds
(we use names later for adding nodes):Deploy slim-dev:
Create and deploy monitoring layer:
Create and deploy metrics-server layer:
Inspect the network policy for scraping of kube nodes:
The
spec:
part is the relevant part, and should contain the IPs of the nodes:Add a node:
Verify the internal IP of the new node:
kubectl get nodes -o custom-columns="NAME:.metadata.name,INTERNAL-IP:.status.addresses[?(@.type=='InternalIP')].address"
Re-get the netpol to verify the new ip is in the
spec:
block:Should now be something like this:
Verify Prometheus can read things
Connect directly to prometheus:
Visit http://localhost:9090/
Execute this expression to see all node/cpu data:
To see just info from the
extra1
node:Add a new node:
Verify the netpol updates:
Re-execute the Prometheus query from above. It make take a few minutes for
extra2
to show up though. Not sure why.Delete a node and verify the spec updates again:
kubectl delete node k3d-extra1-0 && k3d node delete k3d-extra1-0
Re-reading the netpol should should the removal of that IP
Checklist before merging