Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: introduce new uds task file & ci structure #14

Merged
merged 47 commits into from
Nov 7, 2023
Merged

Conversation

jeff-mccoy
Copy link
Member

@jeff-mccoy jeff-mccoy commented Nov 2, 2023

Description

Utilize UDS CLI task runner for all local/remote jobs. This allows us to use the same commands locally or remotely. Also introducing per-capability and complete UDS Core testing in parallel, with fail-fast + custom runners for speed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

jeff-mccoy and others added 29 commits November 2, 2023 02:46
* Initial commit

* update .gitignore

* bump config chart to 0.1.0 and remove zarf package version

* Add loki to uds-core (packages/standard) and add run task for build/test of uds-core package

* remove tasks.yaml that was being used for local dev, Remove require:true from loki base package components

* remove neuvector required:true references

* remove unnecessary imagepullsecrets value from loki values

---------

Co-authored-by: Michael-Kruggel <[email protected]>
* Add commit lint workflow

* add commitlint config
@jeff-mccoy jeff-mccoy changed the title Shiny new toys test: introduce new uds task file & ci structure Nov 4, 2023
@zachariahmiller
Copy link
Contributor

Preliminary thought on this is that what you have in this pr right now is pretty much 100% tracking towards what i envisioned, only caveat being that there isn't a root level run task that can do all the things if you are doing local dev.

That would be trivial to add in the future and would basically emulate the flow you have orchestrated in github workflows on local.

@jeff-mccoy jeff-mccoy marked this pull request as ready for review November 7, 2023 00:53
@zachariahmiller
Copy link
Contributor

zachariahmiller commented Nov 7, 2023

To your last commit message. You can do a fun bash one liner or use this https://github.com/philips-labs/list-folder-action and inline the filter instead of using the yaml file 🫠

I thought the yaml file was the clearest option, albeit verbose

Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have much to say since I've been commenting on the progress along this journey... 🤣 LGTM! 🚀🦄

@jeff-mccoy
Copy link
Member Author

lol yeah yaml wasn't bad really, just started feel like one more area for us to keep up with, but probably not that big of a deal

@jeff-mccoy jeff-mccoy merged commit 6c16add into main Nov 7, 2023
19 checks passed
@jeff-mccoy jeff-mccoy deleted the shiny-new-toys branch November 7, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants