Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate a schema for keycloak helm chart #627

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

samayer12
Copy link
Contributor

@samayer12 samayer12 commented Aug 1, 2024

Description

Using remarshal and generate-json-schema, I locally created a values.schema.json file for keycloak's chart. I also referenced this post to build context on schemas & helm charts.

Related Issue

Fixes #563

Type of change

  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 force-pushed the 563-keycloak-schema branch from d85762e to 7118523 Compare August 1, 2024 19:33
@samayer12 samayer12 changed the title Generate a schema for keycloak helm chart chore: Generate a schema for keycloak helm chart Aug 1, 2024
@samayer12 samayer12 changed the title chore: Generate a schema for keycloak helm chart chore: generate a schema for keycloak helm chart Aug 1, 2024
@lemonprogis
Copy link
Contributor

Hey @samayer12 you'll want to get that commit verified.

@samayer12 samayer12 force-pushed the 563-keycloak-schema branch from 7118523 to 95e9729 Compare August 1, 2024 20:56
@samayer12
Copy link
Contributor Author

samayer12 commented Aug 1, 2024

@lemonprogis, done! It looks like I rebased through the web UI after I opened the PR which then didn't apply a signature. Seems like I'm not the only one who has encountered that issue.

Web commit signing is supported in Enterprise Server 3.13, but apparently not on Free, Pro, or Team instances.

@mjnagel mjnagel requested a review from a team August 1, 2024 22:51
noahpb
noahpb previously approved these changes Aug 2, 2024
Copy link
Contributor

@noahpb noahpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing @samayer12!

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on how we approach the schema here. I think this is a good first pass, noting that it was primarily auto-generated. Might be good to take a look at a couple spots where we can add some missing fields/more strictly enforce the schema.

src/keycloak/chart/values.schema.json Show resolved Hide resolved
src/keycloak/chart/values.schema.json Show resolved Hide resolved
Copy link
Contributor Author

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changes from @mjnagel

src/keycloak/chart/values.schema.json Show resolved Hide resolved
src/keycloak/chart/values.schema.json Show resolved Hide resolved
@samayer12 samayer12 force-pushed the 563-keycloak-schema branch from 9642988 to 7d751cf Compare August 12, 2024 19:28
@samayer12
Copy link
Contributor Author

Rebased with main, as of 77ea6f5

@mjnagel mjnagel enabled auto-merge (squash) August 15, 2024 15:19
@mjnagel mjnagel merged commit cf3a9e7 into main Aug 15, 2024
18 checks passed
@mjnagel mjnagel deleted the 563-keycloak-schema branch August 15, 2024 15:37
mjnagel pushed a commit that referenced this pull request Aug 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.26.0](v0.25.2...v0.26.0)
(2024-08-21)


### ⚠ BREAKING CHANGES

* client attribute allow list
([#676](#676))

### Features

* **azure:** azure blob storage support for velero
([#644](#644))
([eff9a82](eff9a82))
* support authservice with redis, switch to pepr helm chart
([#658](#658))
([e2fe58a](e2fe58a))


### Bug Fixes

* client attribute allow list
([#676](#676))
([100321e](100321e))
* handle client id names with special characters
([#659](#659))
([a84769e](a84769e))
* pull lula main for threshold update
([#638](#638))
([5a34ce8](5a34ce8))
* release-please config bump minor pre-major
([#680](#680))
([3f824c1](3f824c1))


### Miscellaneous

* add watch config to exemption watch
([#682](#682))
([7714ff8](7714ff8))
* **deps:** update grafana helm chart to v8.4.4
([#664](#664))
([77ea6f5](77ea6f5))
* **deps:** update pepr to 0.34.1
([#654](#654))
([6d4655d](6d4655d))
* **deps:** update promtail to v3.1.1
([#657](#657))
([c009e5f](c009e5f))
* **deps:** update test-infra
([#412](#412))
([a4c8fe9](a4c8fe9))
* **deps:** update test-infra (kms) to v0.0.5
([#667](#667))
([bd68637](bd68637))
* **deps:** update test-infra KMS to v0.0.4
([#663](#663))
([3c30b9f](3c30b9f))
* **deps:** update uds to v0.14.1
([#677](#677))
([12ec8a1](12ec8a1))
* **deps:** update velero kubectl image to v1.31.0
([#669](#669))
([d6b2f12](d6b2f12))
* **deps:** update velero to v7.1.5
([#671](#671))
([10ab714](10ab714))
* **deps:** update zarf to v0.38.1
([#616](#616))
([e0cb85d](e0cb85d))
* **deps:** update zarf to v0.38.2
([#668](#668))
([3328925](3328925))
* generate a schema for keycloak helm chart
([#627](#627))
([cf3a9e7](cf3a9e7))
* mute pepr on deploy action for migrating to helm chart
([#683](#683))
([9d05ddd](9d05ddd))
* **neuvector:** update source for unicorn images
([#675](#675))
([568efa2](568efa2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add values.schema.json to keycloak custom chart
5 participants