-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generate a schema for keycloak helm chart #627
Conversation
d85762e
to
7118523
Compare
Hey @samayer12 you'll want to get that commit verified. |
7118523
to
95e9729
Compare
@lemonprogis, done! It looks like I rebased through the web UI after I opened the PR which then didn't apply a signature. Seems like I'm not the only one who has encountered that issue. Web commit signing is supported in Enterprise Server 3.13, but apparently not on Free, Pro, or Team instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing @samayer12!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on how we approach the schema here. I think this is a good first pass, noting that it was primarily auto-generated. Might be good to take a look at a couple spots where we can add some missing fields/more strictly enforce the schema.
4abd8b0
to
9642988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added changes from @mjnagel
9642988
to
7d751cf
Compare
Rebased with |
🤖 I have created a release *beep* *boop* --- ## [0.26.0](v0.25.2...v0.26.0) (2024-08-21) ### ⚠ BREAKING CHANGES * client attribute allow list ([#676](#676)) ### Features * **azure:** azure blob storage support for velero ([#644](#644)) ([eff9a82](eff9a82)) * support authservice with redis, switch to pepr helm chart ([#658](#658)) ([e2fe58a](e2fe58a)) ### Bug Fixes * client attribute allow list ([#676](#676)) ([100321e](100321e)) * handle client id names with special characters ([#659](#659)) ([a84769e](a84769e)) * pull lula main for threshold update ([#638](#638)) ([5a34ce8](5a34ce8)) * release-please config bump minor pre-major ([#680](#680)) ([3f824c1](3f824c1)) ### Miscellaneous * add watch config to exemption watch ([#682](#682)) ([7714ff8](7714ff8)) * **deps:** update grafana helm chart to v8.4.4 ([#664](#664)) ([77ea6f5](77ea6f5)) * **deps:** update pepr to 0.34.1 ([#654](#654)) ([6d4655d](6d4655d)) * **deps:** update promtail to v3.1.1 ([#657](#657)) ([c009e5f](c009e5f)) * **deps:** update test-infra ([#412](#412)) ([a4c8fe9](a4c8fe9)) * **deps:** update test-infra (kms) to v0.0.5 ([#667](#667)) ([bd68637](bd68637)) * **deps:** update test-infra KMS to v0.0.4 ([#663](#663)) ([3c30b9f](3c30b9f)) * **deps:** update uds to v0.14.1 ([#677](#677)) ([12ec8a1](12ec8a1)) * **deps:** update velero kubectl image to v1.31.0 ([#669](#669)) ([d6b2f12](d6b2f12)) * **deps:** update velero to v7.1.5 ([#671](#671)) ([10ab714](10ab714)) * **deps:** update zarf to v0.38.1 ([#616](#616)) ([e0cb85d](e0cb85d)) * **deps:** update zarf to v0.38.2 ([#668](#668)) ([3328925](3328925)) * generate a schema for keycloak helm chart ([#627](#627)) ([cf3a9e7](cf3a9e7)) * mute pepr on deploy action for migrating to helm chart ([#683](#683)) ([9d05ddd](9d05ddd)) * **neuvector:** update source for unicorn images ([#675](#675)) ([568efa2](568efa2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
Using remarshal and generate-json-schema, I locally created a
values.schema.json
file for keycloak's chart. I also referenced this post to build context on schemas & helm charts.Related Issue
Fixes #563
Type of change
Checklist before merging