feat(operator): add finalizer to package CRs to await removals properly #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a k8s finalizer to all
Package
CR resources during initial reconciliation. This will ensure that all packages end up with the finalizer, even on an upgrade.Switching to a finalizer removes the usage/need for Pepr's
.IsDeleted
since we are actually watching for updates now (when a resource is deleted it will have an update with adeletionTimestamp
). The deletion logic was moved to thepackageReconciler
to trigger when adeletionTimestamp
is present. The first step in the deletion logic is patching the Package to a new status of "Deleting".A few notes on the new behavior:
Deleting
phase.Related Issue
Fixes #523
Type of change
Checklist before merging