feat: remove todo #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xShaito
reviewed
Oct 1, 2024
0xJabberwock
requested changes
Oct 1, 2024
src/contracts/CouncilArbitrator.sol
Outdated
Comment on lines
55
to
52
| ) external onlyArbitratorModule returns (bytes memory /* _data */ ) { | ||
| ) external onlyArbitratorModule returns (bytes memory _data) { |
There was a problem hiding this comment.
Hmm, I support keeping solhint's no-unused-vars and commenting unused parameter names. 🤷♂️
Comment on lines
116
to
117
| */ | ||
| event MaxUsersToCheckSetted(uint256 _maxUsersToCheck); |
There was a problem hiding this comment.
In this context, the past participle of set is set, not setted.
There was a problem hiding this comment.
I know, usually we use setted to nuance the meaning, bit I can change it
0xJabberwock
reviewed
Oct 2, 2024
Comment on lines
-232
to
+235
| _balance += _slash(_disputeId, 1, MAX_USERS_TO_CHECK, _result, _status); | ||
| _balance += _slash(_disputeId, 1, maxUsersToCheck, _result, _status); |
There was a problem hiding this comment.
I'd pass a constant (MAX_USERS_TO_SLASH) as argument instead of the magic number.
There was a problem hiding this comment.
I'm good to have it as a constant too (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-182