test(medusa): ebo request creator properties #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJabberwock
commented
Nov 19, 2024
Comment on lines
12
to
15
| function property_canAlwaysCreateRequest(uint256 _epoch, uint256 _chainIdSeed) external { | ||
| try HandlerParent(this).handleCreateRequest(_epoch, _chainIdSeed) {} | ||
| catch { | ||
| assert(false); |
There was a problem hiding this comment.
I think that EpochManager::currentEpoch is not being fuzzed, despite there's MockEpochManager::setEpoch. Should we create HandlerEpochManager for such purpose?
0xJabberwock
commented
Nov 20, 2024
Comment on lines
19
to
20
| // Prevent duplicate chainId for same epoch | ||
| if (_ghost_epochChainIds[_epoch][chainId]) return; |
There was a problem hiding this comment.
Multiple requests for a given epoch and chain ID may be created as long as:
- there is not a previous unfinished request for those arguments;
- there is not a previous finished request with response for those arguments.
0xJabberwock
commented
Nov 20, 2024
Comment on lines
13
to
21
| function property_canAlwaysCreateRequest(uint256 _epoch, uint256 _chainIdSeed) external { | ||
| try HandlerParent(this).handleCreateRequest(_epoch, _chainIdSeed) {} | ||
| _epoch = _boundEpoch(_epoch); | ||
| string memory chainId = _generateChainId(_chainIdSeed); | ||
|
|
||
| // Prevent duplicate chainId for same epoch | ||
| if (_ghost_epochChainIds[_epoch][chainId]) return; | ||
|
|
||
| // Create request via EBORequestCreator | ||
| try eboRequestCreator.createRequest(_epoch, chainId) {} |
There was a problem hiding this comment.
Are property functions state-persistent? If so, protocol interactions that are meant to alter ghost state should always be performed via the appropriate handler.
In the highlighted case, state persistency would oblige to interact via handleCreateRequest() rather than createRequest().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-XXX