refactor: internal library #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorsal
reviewed
Dec 10, 2024
Comment on lines
+55
to
+56
| IOracle.Request memory _request, | ||
| IOracle.Response memory _response |
There was a problem hiding this comment.
I'm worried about this change negatively impacting gas consumption, I need measure it before approving it.
There was a problem hiding this comment.
Tested locally, 2k gas less gas usage with this change.
we need to add gas snapshots to our CI process
xorsal
approved these changes
Dec 12, 2024
gas1cent
approved these changes
Dec 13, 2024
ashitakah
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-575
Closes OPT-570