fix: proposer's bond should not be released when dispute has no resol…

…ution
defi-wonderland · Nov 13, 2024 · c1181ca · c1181ca
1 parent 506a405
commit c1181ca
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/solidity/contracts/modules/dispute/BondedDisputeModule.sol b/solidity/contracts/modules/dispute/BondedDisputeModule.sol
@@ -60,13 +60,6 @@ contract BondedDisputeModule is Module, IBondedDisputeModule {
         _token: _params.bondToken,
         _amount: _params.bondSize
       });
-
-      _params.accountingExtension.release({
-        _bonder: _dispute.proposer,
-        _requestId: _dispute.requestId,
-        _token: _params.bondToken,
-        _amount: _params.bondSize
-      });
     } else if (_status == IOracle.DisputeStatus.Won) {
       // Disputer won, we pay the disputer and release their bond
       _params.accountingExtension.pay({

diff --git a/solidity/test/unit/modules/dispute/BondedDisputeModule.t.sol b/solidity/test/unit/modules/dispute/BondedDisputeModule.t.sol
@@ -169,13 +169,6 @@ contract BondedDisputeModule_Unit_OnDisputeStatusChange is BaseTest {
       abi.encode(IOracle.DisputeStatus.NoResolution)
     );
 
-    // Mock and expect the call to release, for the proposer
-    _mockAndExpect(
-      address(accountingExtension),
-      abi.encodeCall(accountingExtension.release, (mockResponse.proposer, _requestId, _token, _bondSize)),
-      abi.encode()
-    );
-
     // Mock and expect the call to release, for the disputer
     _mockAndExpect(
       address(accountingExtension),