Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase test coverage to 100% #31

Merged
merged 13 commits into from
Dec 12, 2023
Merged

test: increase test coverage to 100% #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b58d723
test: increase some modules test coverage to 100
Dec 8, 2023
db3a18a
test: push changes to remote for review
Dec 11, 2023
a1c00d1
test: fuzzing issue
gas1cent Dec 11, 2023
dca8de5
test: uncomment an assertion
gas1cent Dec 11, 2023
a345956
test: uncomment and refactor `pledgeForDispute` tests
gas1cent Dec 11, 2023
512e3d0
test: uncomment and refactor `pledgeAgainstDispute` tests
gas1cent Dec 11, 2023
5e09c11
refactor: move IWETH interface to testing utils
gas1cent Dec 11, 2023
eab5725
test: test coverage for bonded response module
Dec 12, 2023
9d49aae
fix: verify signature
0xmoebius Dec 12, 2023
60a2286
fix: verify signature
0xmoebius Dec 12, 2023
fdc82e2
Merge branch 'dev' of wonderland:defi-wonderland/prophet-modules into…
0xmoebius Dec 12, 2023
6221018
Update solidity/test/unit/modules/response/BondedResponseModule.t.sol
0xmoebius Dec 12, 2023
12542f3
Update solidity/test/integration/Finalization.t.sol
0xmoebius Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/src/SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@
- [❱ extensions](solidity/interfaces/extensions/README.md)
- [IAccountingExtension](solidity/interfaces/extensions/IAccountingExtension.sol/interface.IAccountingExtension.md)
- [IBondEscalationAccounting](solidity/interfaces/extensions/IBondEscalationAccounting.sol/interface.IBondEscalationAccounting.md)
- [❱ external](solidity/interfaces/external/README.md)
- [IWETH9](solidity/interfaces/external/IWETH9.sol/interface.IWETH9.md)
- [❱ modules](solidity/interfaces/modules/README.md)
- [❱ dispute](solidity/interfaces/modules/dispute/README.md)
- [IBondEscalationModule](solidity/interfaces/modules/dispute/IBondEscalationModule.sol/interface.IBondEscalationModule.md)
Expand Down
6 changes: 2 additions & 4 deletions solidity/test/integration/Finalization.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
address internal _finalizer = makeAddr('finalizer');
IOracle.Request internal _request;
IOracle.Response internal _response;
bytes32 _requestId;

Check warning on line 12 in solidity/test/integration/Finalization.t.sol

View workflow job for this annotation

GitHub Actions / Run Linters (16.x) 

Explicitly mark visibility of state
bytes32 _responseId;

Check warning on line 13 in solidity/test/integration/Finalization.t.sol

View workflow job for this annotation

GitHub Actions / Run Linters (16.x) 

Explicitly mark visibility of state

function setUp() public override {
super.setUp();
Expand Down Expand Up @@ -153,7 +153,7 @@
* @notice Test to check that finalizing a request with a ongoing dispute with revert.
*/
function test_revertFinalizeInDisputeWindow(uint256 _block) public {
vm.assume(_block < _expectedDeadline + _baseDisputeWindow);
_block = bound(_block, block.number, _expectedDeadline - _baseDisputeWindow - 1);
address _callbackTarget = makeAddr('target');
vm.etch(_callbackTarget, hex'069420');

Expand All @@ -179,9 +179,7 @@

vm.roll(_block);
vm.prank(_finalizer);
if (_block < _expectedDeadline + _baseDisputeWindow) {
vm.expectRevert(IBondedResponseModule.BondedResponseModule_TooEarlyToFinalize.selector);
}
vm.expectRevert(IBondedResponseModule.BondedResponseModule_TooEarlyToFinalize.selector);
oracle.finalize(_request, _response);
}
/**
Expand Down
2 changes: 1 addition & 1 deletion solidity/test/integration/IntegrationBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {IResolutionModule} from
import {IFinalityModule} from
'@defi-wonderland/prophet-core-contracts/solidity/interfaces/modules/finality/IFinalityModule.sol';

import {IWETH9} from '../../interfaces/external/IWETH9.sol';
import {IWETH9} from '../utils/external/IWETH9.sol';

import {HttpRequestModule, IHttpRequestModule} from '../../contracts/modules/request/HttpRequestModule.sol';
import {BondedResponseModule, IBondedResponseModule} from '../../contracts/modules/response/BondedResponseModule.sol';
Expand Down
182 changes: 0 additions & 182 deletions solidity/test/invariant/InvariantsTest.t.sol
View file
Open in desktop

This file was deleted.

Loading
Loading