Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fuzz and bound enums #43

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions solidity/test/unit/modules/resolution/ArbitratorModule.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ contract ArbitratorModule_Unit_ModuleData is BaseTest {
* @notice Test that the status is correctly retrieved
*/
function test_getStatus(uint256 _status, bytes32 _disputeId) public {
_status = bound(_status, 0, uint256(IArbitratorModule.ArbitrationStatus.Resolved));
vm.assume(_status <= uint256(IArbitratorModule.ArbitrationStatus.Resolved));
IArbitratorModule.ArbitrationStatus _arbitratorStatus = IArbitratorModule.ArbitrationStatus(_status);

// Store the mock dispute
Expand Down Expand Up @@ -233,8 +233,7 @@ contract ArbitratorModule_Unit_ResolveDispute is BaseTest {
}

function test_emitsEvent(uint256 _status, address _arbitrator) public assumeFuzzable(_arbitrator) {
vm.assume(_status <= uint256(IOracle.DisputeStatus.Lost));
vm.assume(_status > uint256(IOracle.DisputeStatus.Escalated));
_status = bound(_status, uint256(IOracle.DisputeStatus.Escalated) + 1, uint256(IOracle.DisputeStatus.Lost));
IOracle.DisputeStatus _arbitratorStatus = IOracle.DisputeStatus(_status);

mockRequest.resolutionModuleData = abi.encode(_arbitrator);
Expand Down
Loading