fix: adding escalated status check #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xShaito
requested changes
Jul 9, 2024
solidity/contracts/modules/resolution/PrivateERC20ResolutionModule.sol
Outdated
Show resolved
Hide resolved
| if (ORACLE.disputeStatus(_disputeId) != IOracle.DisputeStatus.None) { | ||
| if ( | ||
| ORACLE.disputeStatus(_disputeId) != IOracle.DisputeStatus.None | ||
| && ORACLE.disputeStatus(_disputeId) != IOracle.DisputeStatus.Escalated |
There was a problem hiding this comment.
The finding only says to check against IOracle.DisputeStatus.Escalated. Does it also need to keep None? What is that case?
There was a problem hiding this comment.
Yep we should left the None also, is the other case which the dispute can be voted
There was a problem hiding this comment.
@0xShaito @0xJabberwock the None status means the dispute has not started yet.
There are 2 somewhat realistic scenarios that could lead to a dispute having the None in this function:
- The ID is incorrect, in which case
ORACLE.createdAt(_disputeId) == 0effectively duplicates this check. - The dispute was created in a messed up module that somehow called the
updateDisputeStatusfunction of the oracle and set an invalid status.
The second point is a bit concerning but the off-chain logic should catch that, so I would remove the None check.
… fix/dispute-lock
…-modules into fix/dispute-lock
0xShaito
previously approved these changes
Jul 16, 2024
0xJabberwock
requested changes
Jul 16, 2024
solidity/contracts/modules/resolution/PrivateERC20ResolutionModule.sol
Outdated
Show resolved
Hide resolved
0xJabberwock
approved these changes
Jul 18, 2024
0xShaito
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-7