fix: not pledged #47
fix: not pledged #47
Conversation
| @@ -33,6 +35,8 @@ contract BondEscalationAccounting is AccountingExtension, IBondEscalationAccount | |||
|
|
|||
| pledges[_disputeId][_token] += _amount; | |||
|
|
|||
| pledgerHasPledged[_disputeId][_pledger] = true; | |||
There was a problem hiding this comment.
Can't the same pledger pledge multiple times? This would kill that right?
There was a problem hiding this comment.
Yep, but as far I know if the resolution is non, the user can claim their pledge 1 time, so with that will be solve I guess.
There was a problem hiding this comment.
Missed the check for amount of pledges. You are right! Tests are failing though
| @@ -33,6 +35,8 @@ contract BondEscalationAccounting is AccountingExtension, IBondEscalationAccount | |||
|
|
|||
| pledges[_disputeId][_token] += _amount; | |||
|
|
|||
| pledgerHasPledged[_disputeId][_pledger] = true; | |||
There was a problem hiding this comment.
Missed the check for amount of pledges. You are right! Tests are failing though
| @@ -462,6 +476,8 @@ contract BondEscalationAccounting_Unit_ClaimEscalationReward is BaseTest { | |||
|
|
|||
| bondEscalationAccounting.forTest_setPledge(_disputeId, token, _amount * _pledges); | |||
|
|
|||
| bondEscalationAccounting.forTest_setPledgerHasPledged(_disputeId, pledger, true); | |||
There was a problem hiding this comment.
Do we have a test for someone who pledged multiple times?
…-modules into feat/not-pledged
| @@ -356,8 +356,8 @@ contract Integration_BondEscalation is IntegrationBase { | |||
|
|
|||
| // Step 10: Participants claim their rewards | |||
| // Test: The requester has paid out the reward and is left with no balance | |||
| _bondEscalationAccounting.claimEscalationReward(_disputeId, requester); | |||
| assertEq(_bondEscalationAccounting.balanceOf(requester, usdc), 0, 'Mismatch: Requester balance'); | |||
| // _bondEscalationAccounting.claimEscalationReward(_disputeId, requester); | |||
| _disputeId, _requestId, token, _amount, IBondEscalationModule(_bondEscalationModule) | ||
| ); | ||
|
|
||
| bondEscalationAccounting.forTest_setPledge(_disputeId, token, _amount * _pledges * 2); |
There was a problem hiding this comment.
Can we have a different number of pledges for and against so we are sure we are adding both numbers correctly?
🤖 Linear
Closes GRT-8
The problem is that according to the report when the dispute is in non-resolution, everyone can access a pledge. The issue is that it doesn't check if that user made a previous pledge and anyone could subtract it in that state.
I have opted to create a mapping that both this in no resolution or if when you make a pledge you put it in true and if not in false, I do not know if it solves the problem 100%.
REVIEW!