fix: request id validation

[0xJabberwock]

🤖 Linear

Closes GRT-3

[linear]

GRT-3 TOB-WOND-4

[0xJabberwock]

TOB-WOND-4 explicitly mentions that the dispute's requestId validation issue could be found within BondEscalationResolutionModule, BondEscalationModule, PrivateERC20ResolutionModule and ERC20ResolutionModule. However, I was able to detect the lack of the same recommended check around many other modules. Should this be a concern?

Besides, other similar validations are also extendedly absent, such as comparing with the response's requestId or the dispute's responseId. Again, should this be a concern?

[0xJabberwock]

This custom error is not being used anywhere. 🙄

[0xJabberwock]

TOB-WOND-4 explicitly mentions that the dispute's requestId validation issue could be found within BondEscalationResolutionModule, BondEscalationModule, PrivateERC20ResolutionModule and ERC20ResolutionModule. However, I was able to detect the lack of the same recommended check around many other modules. Should this be a concern?

It should not. This is due to every function lacking requestId checks being onlyOracle, contract where the appropriate validations are being performed.

Besides, other similar validations are also extendedly absent, such as comparing with the response's requestId or the dispute's responseId. Again, should this be a concern?

It should not be it outside of the warned modules, for the same reason; within the warned modules, there was one case where a responseId validation was due.