fix: response module deadline #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJabberwock
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Do the following lines found in BondEscalationModule make sense, considering that responseCreatedAt returns a block number and that disputeWindow is expressed in number of seconds as per the interface?
if (block.number > ORACLE.responseCreatedAt(_dispute.responseId) + _params.disputeWindow) {
revert BondEscalationModule_DisputeWindowOver();
}A similar construction can be found in the BondedResponseModule as well, although there the tests seem to acknowledge that the disputeWindow is a number of blocks.
Moreover, when looking at the same dispute module, every deadline and disputeWindow is expressed in terms of block timestamps, diverging from what this PR intends to establish in BondedResponseModule.
Comment on lines
30
to
+31
| // Cannot propose after the deadline | ||
| if (block.timestamp >= _params.deadline) revert BondedResponseModule_TooLateToPropose(); | ||
| if (block.number >= _params.deadline) revert BondedResponseModule_TooLateToPropose(); |
There was a problem hiding this comment.
Revise the interface NatSpec for the deadline param.
ashitakah
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.