Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use block.timestamp instead of block.number #63

Merged
merged 11 commits into from
Oct 2, 2024

Conversation

xorsal
Copy link
Contributor

@xorsal xorsal commented Sep 26, 2024

🤖 Linear

Closes OPO-647

Tests pass using this version of prophet-core.

Copy link

linear bot commented Sep 26, 2024

This should be a temporary change.
package.json Outdated
@@ -38,7 +38,7 @@
"package.json": "sort-package-json"
},
"dependencies": {
"@defi-wonderland/prophet-core": "0.0.0-0954a47f",
"@defi-wonderland/prophet-core": "github:defi-wonderland/prophet-core#de18a05",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait till defi-wonderland/prophet-core#46 is merged, release a new canary of the core package and use it here.

Copy link
Member

@gas1cent gas1cent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, waiting for the core PR to be merged.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@0xJabberwock 0xJabberwock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gas1cent gas1cent merged commit 2d91875 into dev Oct 2, 2024
3 checks passed
@gas1cent gas1cent deleted the feat/rollback-to-timestamps branch October 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants