test: resolution tests #68
Conversation
| // review: should we allow an alternative to this gas consuming approach? | ||
| // we could add a configurable param to skip the forced token mass-transfer, and let users do it manually. |
There was a problem hiding this comment.
I also found this recommendation: https://www.notion.so/defi-wonderland/Internal-Report-69aa58aab1024d5b81bf24631c86636d
I'd prefer to allow a way to skip the mass transfer, but we could leave it for later :)
|
|
||
| // warp past the revealing window | ||
| vm.warp(block.timestamp + _revealingTimeWindow); | ||
| oracle.resolveDispute(mockRequest, mockResponse, mockDispute); |
There was a problem hiding this comment.
Add more actions in the middle. For example a user trying to claimVote in the middle and it should fail
There was a problem hiding this comment.
Cast vote into something that doesn't exist or that is already resolved
I found two bugs in ERC20Resolution: - `claimVote` allows voters to withdraw their casted votes any number of any number of times. A voter could cast a single vote into a resolution and call `claimVote` until all votes from a resolution are withdrawn. - when you try to resolve a not escalated dispute it reverts with `ERC20ResolutionModule_AlreadyResolved`. This one also happens in PrivateERC20Resolution.
|
I found two bugs in ERC20Resolution:
|
|
Also needed to merge with dev, branch conflicts |
|
We've discovered 2 bugs in the modules that are not going to be used in EBO. Converting this PR to a draft to return to it after finishing EBO. |
🤖 Linear
Closes OPT-516