feat: validating time deltas #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken-locking into feat/unlock-with-withdrawal
…onderland/token-locking into feat/timedelta
…onderland/token-locking into feat/timedelta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a set of possible time-deltas should be allowed (e.g.) 0 (for unlocked with withdrawal period), 1 month, 3 months, and so on... The locking method should revert if the user tries to lock for a different amount of time.
This PR replaces the concept of Dates when creating a lockup, since the user will be inputting a TimeDelta, and internally we should calculate the Date, to keep the same infra as it was.