Fixes broken input of modifier characters on MacOSX. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WolfgangD Could you provide a test for the modified code? Thanks. |
|
This issue has been resolved by PR #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25 by checking if the character next to the caret is one of MacOS X supported modifier characters. If this is the case the checker isn't run.
It also does not check if such a character is copy/pasted. However this has no negative effect as the checker will run again when the next character is input.
The modifiers are exhaustive according to http://guides.macrumors.com/Typing_with_extended_characters. If more are added they can easily be added to the
modifierCharactersarray.Further discussion
I would have preferred a solution where the special input state (OS is waiting for the second character) is detected but haven't found a way. For a Chrome Extension it looks like a normal character has been entered.