Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CLI give better errors #80

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Make CLI give better errors #80

merged 2 commits into from
Feb 28, 2024

Conversation

davidsiaw
Copy link
Contributor

If you attempt to connect somewhere that no longer exists like

bcn login http://doghouse.snoopy <- this used to work but now does not

and try

bcn district list

Instead of getting

Failed to parse error. Use `bcn -d` to see raw server response
invalid character '<' looking for beginning of value

This PR gives you

HTTP Error:503 Service Temporarily Unavailable
Type bcn -d <command> for details

@degikko
Copy link

degikko commented Feb 19, 2024

@Iorin0225 can you help us review this PR, please?

@degikko degikko requested a review from Iorin0225 February 19, 2024 06:08
Iorin0225
Iorin0225 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Iorin0225 Iorin0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Iorin0225 Iorin0225 merged commit 5b566bd into master Feb 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iorin0225 Iorin0225 Iorin0225 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsiaw @degikko @Iorin0225