Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate bcn run command #81

Closed
wants to merge 1 commit into from
Closed

Deprecate bcn run command #81

wants to merge 1 commit into from

Conversation

showwin
Copy link

@showwin showwin commented Jul 8, 2024 •
edited
Loading

N/A

@showwin showwin marked this pull request as ready for review July 9, 2024 07:22
@degikko degikko requested a review from ochko July 9, 2024 07:22
@degikko
Copy link

degikko commented Jul 9, 2024

@ochko can you help us review this PR, please?

@degikko degikko requested a review from davidsiaw July 10, 2024 05:38
@degikko
Copy link

degikko commented Jul 10, 2024

@davidsiaw can you help us review this PR, please?

@showwin showwin requested a review from Daivasmara July 11, 2024 05:55
davidsiaw
davidsiaw requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@davidsiaw davidsiaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of policy we should hold off on this until we know ecs-exec can work. Also do not forget that this is an open source program, and this is actually a piece of tooling that can and may still be used by others.

@davidsiaw
Copy link
Contributor

@showwin please remove the images and text pertinent to the internals of the organization. this is an open source project

@showwin
Copy link
Author

showwin commented Jul 12, 2024

@davidsiaw
Ah, yes. I forgot about that. Then, let's close this PR. 🙏

@showwin showwin closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsiaw davidsiaw davidsiaw requested changes

@ochko ochko Awaiting requested review from ochko

@Daivasmara Daivasmara Awaiting requested review from Daivasmara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@showwin @degikko @davidsiaw