Add - in the middle

degica · Aug 14, 2024 · 8e33e86 · 8e33e86
1 parent a02a160
commit 8e33e86
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/degica_datadog/config.rb b/lib/degica_datadog/config.rb
@@ -30,7 +30,11 @@ def service
       end
 
       def version
-        @version || (ENV.fetch("PLATFORM", "") + ENV.fetch("_GIT_REVISION", "unknown"))
+        return @version if @version
+
+        platform = ENV.fetch("PLATFORM", "")
+        git_revision = ENV.fetch("_GIT_REVISION", "unknown")
+        platform.empty? ? git_revision : "#{platform}-#{git_revision}"
       end
 
       def environment

diff --git a/spec/config_spec.rb b/spec/config_spec.rb
@@ -77,7 +77,7 @@
       end
 
       it "sets version correctly" do
-        expect(described_class.version).to eq("#{platform}#{version}")
+        expect(described_class.version).to eq("#{platform}-#{version}")
       end
     end
   end
-Original file line number
+Diff line change
@@ Expand Up / @@ -77,7 +77,7 @@ @@
           end
           it "sets version correctly" do
-            expect(described_class.version).to eq("#{platform}#{version}")
+            expect(described_class.version).to eq("#{platform}-#{version}")
           end
         end
       end
@@ Expand Down @@