Restore Quote when clicking browser back button #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinwy
force-pushed
the
feature/restoreQuote
branch
from
a2f2831 to
41ae462
Compare
Dinwy
changed the title
rramsden
reviewed
May 31, 2024
| use Magento\Quote\Api\CartRepositoryInterface; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| class RestoreQuoteFromSession implements ObserverInterface |
There was a problem hiding this comment.
@Dinwy We should add some module documentation here explaining why this class exists.
There was a problem hiding this comment.
Thank you for the feedback! I will add a document for this module. WIP
There was a problem hiding this comment.
@rramsden I've added doc block and documentation for events and observers
Please check and let me know how you think!
rramsden
approved these changes
May 31, 2024
Dinwy
changed the title
Dinwy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses critical issues and improvements for the Komoju Payments module in Magento, focusing on webhook error fixes, code cleanup, and enhanced payment flow.
Key Changes
Restore Quote
Webhook Error Fixes:
Code Cleanup:
Videos
komoju-magento_bacButton_behaviour.mp4