Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update enhances the Komoju-Magento plugin with the following key changes and improvements:
Improved Refund Handling:
Code Cleanup and Refactoring:
Detailed Changes
WebhookEventProcessor.php:
Without setting baseTotalPaid, the refund logic was throwing errors. This is likely because the validation method validate checks if the base order refund exceeds the base total paid. If baseTotalPaid is not correctly set, this check can fail and cause errors when writing credit memo.
https://github.com/pepe1518/magento2/blob/master/vendor/magento/module-sales/Model/Service/CreditmemoService.php#L213
Quote from: https://experienceleague.adobe.com/en/docs/commerce-admin/stores-sales/order-management/orders/order-status
Attachments
How it looks like after processing 3 partial refund
Please review these changes and merge the PR if everything looks good. Thank you!