Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing IPN flakiness #102

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Try fixing IPN flakiness #102

merged 4 commits into from
Feb 6, 2024

Conversation

Resonious
Copy link
Member

@Resonious Resonious commented Feb 1, 2024

We got a bug report about webhooks getting dropped after automatic updates. I noticed that we're not following the official advice on hooks within gateway initializers, which might be the cause. This PR moves the API action registration outside of the gateway initialization code. Hopefully this fixes the issue.

I had a hard time reproducing the original issue, but I was able to confirm that this change doesn't break regular webhook processing.

@Resonious Resonious force-pushed the fix-ipn-handler-loading-issue branch from ac3e69b to 2fa38cd Compare February 2, 2024 01:56
@FTLam11
Copy link
Contributor

FTLam11 commented Feb 2, 2024

@Resonious Just heads up I'm investigating one cypress admin test it lets me change the KOMOJU endpoint that keeps failing in CI. The test is passing on master when I run on my machine with the same node, cypress, and browser versions though... 😢

@Resonious
Copy link
Member Author

Thanks for the heads up 🙏

@Resonious
Copy link
Member Author

Strange. I can see in the screenshot that it is "waiting for page to load" when the page is quite clearly loaded.
KOMOJU for WooCommerce Admin -- lets me change the KOMOJU endpoint (failed) (attempt 3)

@CicadaMikoto
Copy link

Not related to this issue, per se, but I noticed that that screenshot has some keys in it. Are those dev-only keys or are they publicly usable?

@Resonious
Copy link
Member Author

@CicadaMikoto Yes, no worries. It's for a test mode account. You can annoy us by using the keys but can't cause damage. I appreciate the concern!

@CicadaMikoto
Copy link

Glad to hear it! I went ahead and submitted it on the VDP, just in case. Glad it's not a big impact.

@FTLam11 FTLam11 mentioned this pull request Feb 5, 2024
@Resonious Resonious force-pushed the fix-ipn-handler-loading-issue branch from 2fa38cd to c09b4d8 Compare February 5, 2024 02:59
@Resonious Resonious merged commit d34f4b7 into master Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants