Skip creating checkout session when the cart is empty #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinwy
force-pushed
the
fix/skipCreateSessionWhenCartEmpty
branch
from
c1f7c6a to
346b986
Compare
makotom
reviewed
Dec 13, 2024
Dinwy
force-pushed
the
fix/skipCreateSessionWhenCartEmpty
branch
from
963cef1 to
7ed4a52
Compare
|
Since we fixed e2e test problem. I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
After having discussion, decided not to create checkout session when cart is null.
Screenshots
In admin page (No checkout block incompatible error)
Able to add checkout block in sample page & rednering