Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tl/set governor on turbo state #80

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

tonylambiris
Copy link
Contributor

This will set the governor policy when switching turbo states:

➜ sudo ./src/cpufreqctl turbo get
0
➜ find /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor -exec cat {} + | uniq
powersave
➜ sudo ./src/cpufreqctl turbo 1
➜ sudo ./src/cpufreqctl turbo get
1
➜ find /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor -exec cat {} + | uniq
performance

@tonylambiris
Copy link
Contributor Author

@martin31821 if I could get an extra set of eyes and opinion on this, thanks!

@martin31821
Copy link
Member

I'll take a look, maybe @fin_ger too?

@martin31821
Copy link
Member

@tonylambiris What's the point on setting the governer to powersave when turbo boost is disabled?
Also, I'd like to cherry pick the relevant commits, since there are some changes.

@fin-ger
Copy link
Member

fin-ger commented Feb 17, 2020

I think setting the governor in the profile settings is the more appropriate way of integrating a governor selection into the extension. I don't think the governor should be coupled with the turbo boost setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants