Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests/apps_test.go): do not log lengthy byte output on test failure #363

Closed
wants to merge 1 commit into from
Closed

fix(tests/apps_test.go): do not log lengthy byte output on test failure #363

wants to merge 1 commit into from

Conversation

vdice
Copy link
Member

@vdice vdice commented May 30, 2017

Closes #360

@vdice vdice added this to the v2.15 milestone May 30, 2017
@vdice vdice self-assigned this May 30, 2017
@vdice
Copy link
Member Author

vdice commented May 30, 2017

Darn; it seems ginkgo logs output if/when test fails; no matter how it is failed. Need to find out how to disable this for a particular test...

@vdice vdice mentioned this pull request May 30, 2017
Closed
@vdice vdice modified the milestones: v2.16, v2.15 May 31, 2017
@vdice
Copy link
Member Author

vdice commented May 31, 2017

fix/solution for #360 looks like it needs a diff approach; closing for now.

@vdice vdice closed this May 31, 2017
@vdice vdice deleted the fix/no-lengthy-output-logging branch May 31, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchauncey jchauncey jchauncey approved these changes

Assignees

@vdice vdice

Labels
LGTM1
Projects
None yet
Milestone
v2.16
Development

Successfully merging this pull request may close these issues.
3 participants
@vdice @jchauncey @deis-admin