Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow callers from some files to be ignored #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeweaver
Copy link

No description provided.

@mikeweaver
Copy link
Author

This is for #123

@mikeweaver
Copy link
Author

@dejan Any chance I can get this into the mainline?

@gogiel
Copy link
Collaborator

gogiel commented Jul 4, 2019

Due to recent changes this PR is no longer valid. @mikeweaver are you interested in fixing it?

@mikeweaver
Copy link
Author

Yes, I'm interested in fixing it...if it gets merged to the mainline this time around. Two years gathering dust taxes one's motivation. :-)

@gogiel
Copy link
Collaborator

gogiel commented Jul 6, 2019

Great to hear from you :)
I have a collaborator status. Once you update the PR I'll be able to review and merge to master.

However I can't guarantee the due date for a new gem version release as it's beyond my capabilities.

Thanks.

@mikeweaver
Copy link
Author

@gogiel I rebased my changes onto the latest master and have a green build. Should be good to merge. LMK if I missed something.

@modosc
Copy link
Collaborator

modosc commented Jul 21, 2019

@gogiel i can get this gem released once it's merged, just ping me.

@gogiel
Copy link
Collaborator

gogiel commented Jul 23, 2019

@mikeweaver thanks! I see that you're introducing new concept of config YAML files.
How about using currently existing solution of configuration block?

I believe that configuration in Ruby code is more flexible and simple.
We can add YAML config too but it should be consistent with all existing config options.

Please rebase master again. I reverted accidentally removed code in Config, #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants