Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Localstack setup, and additional installation instructions #2472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KaelenProctor
Copy link

While setting up Cube Cobra locally (using Windows Subsystem for Linux, but that should have no effect in comparison to a regular Linux system) I ran into a few complications which this PR resolves.

Manual testing:

  1. Used an Ubuntu 22.04 virtual machine to complete setup with fixes along the way, until I was able to successfully run Cube Cobra locally including the cards from Scryfall
  2. Started a fresh Ubuntu 24.04 virtual machine and ran through the install steps one by one from scratch, to ensure all dependencies were installed and in correct versions

Concerns:

  1. The yarn lock appears to have been reverted to the yarn 1.X format within this commit a month ago. While this is easily correctable with a yarn install back to the Yarn 4.X format (to match the package.json requirements), and I plan to open another PR to fix that, in my testing I found that Yarn 1 and 4 will complain about each other.
    • For example with Yarn 1.X it will complain about the package.json requiring yarn 4.4.0 when you install, thus unsure how the lock file format got reverted
    • I have not been able to find a lint or yarn command to ensure the yarn.lock file is the correct 4.X format in order to add to the CI validation (or git commit hook ideally)
  2. I'm not a python expert and with recent Linux distributions disallowing system wide package installs in favour of virtual environments, I'm not confident on the awslocal install instructions are best practice nor conflicting with people's existing python setups. So I am also working on a full docker compose setup to help isolate all the dependencies for the build and setup processes, if that is a desirable outcome (I'll ask in the Discord).

@@ -1,4 +1,4 @@
import fs from 'fs';
const fs = require('fs');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to run this with import gave an error about only modules being allowed to use import. The other one shot scripts use require and that made it executable, so even though my experience with ES6 imports vs CommonJS is minor this seems the correct resolution

@KaelenProctor KaelenProctor marked this pull request as ready for review October 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant