Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Refactor - MatcherResults and metrics #70

Merged
merged 11 commits into from
Jan 31, 2024

Remove unused import

5dc95df
Select commit
Loading
Failed to load commit list.
Merged

API Refactor - MatcherResults and metrics #70

Remove unused import
5dc95df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 25, 2024 in 0s

87.15% (+0.79%) compared to 96430e7

View this Pull Request on Codecov

87.15% (+0.79%) compared to 96430e7

Details

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (96430e7) 86.36% compared to head (5dc95df) 87.15%.

Files Patch % Lines
valentine/metrics/base_metric.py 88.23% 2 Missing ⚠️
valentine/algorithms/matcher_results.py 98.00% 1 Missing ⚠️
valentine/metrics/metric_helpers.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   86.36%   87.15%   +0.79%     
==========================================
  Files          37       40       +3     
  Lines        1679     1760      +81     
==========================================
+ Hits         1450     1534      +84     
+ Misses        229      226       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.