Make fromApplication call non-blocking the UI thread #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helios66
approved these changes
Mar 15, 2024
| @@ -21,9 +23,11 @@ public class WhetstoneWorkerInitializer : Initializer<WorkManager> { | |||
|
|
|||
|
|
|||
| private fun Whetstone.installWorkerFactory(application: Application) { | |||
There was a problem hiding this comment.
random thought, non-blocking. is there merit to making this function a suspending function called in a coroutine scope? those are also non-blocking even when called on the main thread. cc @vsdeni
msfjarvis
added a commit
to msfjarvis/whetstone
that referenced
this pull request
Mar 15, 2024
* upstream/main: Prepare for release 0.8.0 Revert "Prepare for release X.Y.Z" Prepare for release X.Y.Z Make fromApplication call non-blocking the UI thread (deliveryhero#94)
msfjarvis
added a commit
to msfjarvis/whetstone
that referenced
this pull request
Aug 29, 2024
* 'main' of https://github.com/deliveryhero/whetstone: Prepare next development version 0.8.5-SNAPSHOT. Update sonatype credentials. Prepare next development version. Prepare for release. [MDEVVEL-9] Update dagger version (deliveryhero#99) Prepare next development version. Prepare for release 0.8.2. Revert the deliveryhero#94 (deliveryhero#98) Prepare next development version. Prepare for release 0.8.1. Return nulls from MultibindingWorkerFactory for non-existent Worker classes instead of throwing exceptions (deliveryhero#96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offload call to the
fromApplicationmethod to IO dispatcher, so that it doesn't block UI thread when creating AppComponent.This should help to avoid possible ANRs on low-end devices, when the component creation might also clash with GC and cause a delay.