Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-1122] removing done TODOs #1127

Merged
merged 7 commits into from
Mar 25, 2024
Merged

[issue-1122] removing done TODOs #1127

merged 7 commits into from
Mar 25, 2024

Conversation

katarzyna-kulpa
Copy link
Collaborator

Purpose

Resolves #1123 (#1122)

Removing TODOs that are already done.

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Provide test details

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (894a0fa) to head (b12105a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   70.34%   70.30%   -0.04%     
==========================================
  Files         106      106              
  Lines       10487    10478       -9     
==========================================
- Hits         7377     7367      -10     
- Misses       2811     2812       +1     
  Partials      299      299              
Flag Coverage Δ
unittests 70.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katarzyna-kulpa katarzyna-kulpa merged commit 001ed3b into master Mar 25, 2024
5 of 6 checks passed
@katarzyna-kulpa katarzyna-kulpa deleted the issue-1122 branch March 25, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set new release version v1.6.2 on rel/cmo-8.0 branch
4 participants