Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for several scenarios #244

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Added unit tests for several scenarios #244

merged 1 commit into from
Nov 9, 2023

Conversation

delldubey
Copy link
Contributor

@delldubey delldubey commented Nov 8, 2023 •
edited by shanmydell
Loading

Description

  • Added unit test scenarios for file system and others.

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test

boyamurthy
boyamurthy approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delldubey delldubey merged commit 988bf42 into main Nov 9, 2023
3 of 4 checks passed
@shanmydell shanmydell deleted the unit_test_coverage branch November 9, 2023 08:51
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@delldubey @Sahiba-Gupta
Added unit tests for several scenarios (#244)
f9dc852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@shanmydell shanmydell shanmydell approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@mjsdell mjsdell Awaiting requested review from mjsdell

@nidtara nidtara Awaiting requested review from nidtara

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

@tssushma tssushma Awaiting requested review from tssushma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delldubey @shanmydell @boyamurthy