Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update driver to load reverseproxy TLS certificate #399

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Jan 6, 2025

Description

Update PowerMax to read the reverse proxy TLS certificate and load it into the certificate pool. This PR resolves the cannot validate certificate for 0.0.0.0 because it doesn't contain any IP SANs error when skipCertificateValidation is set to false.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1571

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Deployed the driver using Helm with reverse proxy configured as a sidecar and skipCertificateValidation set to false, then successfully executed the cert-csi scale test.
  • Deployed the driver using Helm with reverse proxy configured as a sidecar and skipCertificateValidation set to true, then successfully executed the cert-csi scale test.
  • Deployed the driver using Helm with reverse proxy configured as a deployment and skipCertificateValidation set to false, then successfully executed the cert-csi scale test.
  • Deployed the driver using Helm with reverse proxy configured as a deployment and skipCertificateValidation set to true, then successfully executed the cert-csi scale test.

@AkshaySainiDell AkshaySainiDell changed the title [WIP] Fix 1571 subject alt name Update driver to load reverseproxy TLS certificate Jan 8, 2025
@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review January 8, 2025 06:28
@AkshaySainiDell AkshaySainiDell merged commit 8db5f29 into main Jan 8, 2025
6 checks passed
@AkshaySainiDell AkshaySainiDell deleted the fix-1571-subject-alt-name branch January 8, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants