Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yaml for config tests #454

Merged

Conversation

bharathsreekanth
Copy link
Contributor

@bharathsreekanth bharathsreekanth commented Feb 10, 2025

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

make unit-test | grep coverage

coverage: 90.3% of statements
ok revproxy/v2 3.379s coverage: 90.3% of statements
coverage: 100.0% of statements
ok revproxy/v2/pkg/cache 0.067s coverage: 100.0% of statements
coverage: 92.0% of statements
ok revproxy/v2/pkg/common 2.069s coverage: 92.0% of statements
coverage: 90.9% of statements
ok revproxy/v2/pkg/config 1.113s coverage: 90.9% of statements
coverage: 92.4% of statements
ok revproxy/v2/pkg/k8smock 0.175s coverage: 92.4% of statements
coverage: 90.2% of statements
ok revproxy/v2/pkg/k8sutils 0.230s coverage: 90.2% of statements
coverage: 91.6% of statements
ok revproxy/v2/pkg/proxy 0.514s coverage: 91.6% of statements
coverage: 100.0% of statements
ok revproxy/v2/pkg/servermock 0.065s coverage: 100.0% of statements
coverage: 90.6% of statements
ok revproxy/v2/pkg/utils 0.458s coverage: 90.6% of statements

@bharathsreekanth bharathsreekanth changed the base branch from main to usr/spark/unit-test-improvements February 10, 2025 21:01
@bharathsreekanth bharathsreekanth merged commit 9895461 into usr/spark/unit-test-improvements Feb 10, 2025
6 of 7 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/fix-unit-tests branch February 10, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants