Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omevv compliance info]: Fetch the firmware compliance info of a cluster or host in a cluster #762

Conversation

ABHISHEK-SINHA10
Copy link
Collaborator

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 commented Nov 5, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@reetivel reetivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review comments added

docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_compliance_info.rst Outdated Show resolved Hide resolved
@rajshekarp87 rajshekarp87 added the validation/in-progress Validation is in progress label Nov 13, 2024
@rajshekarp87 rajshekarp87 added this to the v9.9.0 milestone Nov 13, 2024
@ShivamSh3 ShivamSh3 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Nov 13, 2024
ShivamSh3
ShivamSh3 previously approved these changes Nov 13, 2024
@sachin-apa sachin-apa removed the request for review from singh-lovepreet1 November 13, 2024 10:43
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 merged commit 5e8988c into dell:collections Nov 13, 2024
31 checks passed
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 deleted the feature/omevv_compliance_info branch November 13, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
Development

Successfully merging this pull request may close these issues.

7 participants