Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[omevv_baseline_profile_info] - Fetch baseline profile information #765

Open
wants to merge 7 commits into
base: collections
Choose a base branch
from
Open

[omevv_baseline_profile_info] - Fetch baseline profile information #765

wants to merge 7 commits into from
+886 −1

Conversation

Kritika-Bhateja-03
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@Kritika-Bhateja-03 Kritika-Bhateja-03 marked this pull request as draft November 12, 2024 06:21
@rajshekarp87 rajshekarp87 added the validation/in-progress Validation is in progress label Nov 13, 2024
@rajshekarp87 rajshekarp87 added this to the v9.9.0 milestone Nov 13, 2024
@rajshekarp87 rajshekarp87 changed the title Module: omevv_baseline_profile_info [omevv_baseline_profile_info] - Fetch baseline profile information Nov 13, 2024
@Kritika-Bhateja-03 Kritika-Bhateja-03 marked this pull request as ready for review November 14, 2024 09:29
sachin-apa
sachin-apa reviewed Nov 14, 2024
View reviewed changes
playbooks/omevv/omevv_baseline_profile_info.yml
- name: Retrieve all baseline profile information.
dellemc.openmanage.omevv_baseline_profile_info:
hostname: "{{ hostname }}"
vcenter_uuid: "{{ vcenter_uuid }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to add a task on how do we fetch the venter uuid and pass to the module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-apa sachin-apa sachin-apa left review comments

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 Awaiting requested review from ABHISHEK-SINHA10 ABHISHEK-SINHA10 is a code owner

@rajshekarp87 rajshekarp87 Awaiting requested review from rajshekarp87 rajshekarp87 is a code owner

@ShivamSh3 ShivamSh3 Awaiting requested review from ShivamSh3 ShivamSh3 is a code owner

@singh-lovepreet1 singh-lovepreet1 Awaiting requested review from singh-lovepreet1

At least 2 approving reviews are required to merge this pull request.

Assignees

@Kritika-Bhateja-03 Kritika-Bhateja-03

Labels
validation/in-progress Validation is in progress
Projects
OpenManage Ansible Collection
Status: In progress
Milestone
v9.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kritika-Bhateja-03 @ansible-collections-svc @sachin-apa @rajshekarp87 @Saksham-Nautiyal