Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added secret inheritance for release action #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added secret inheritance for release action #83

wants to merge 1 commit into from

Conversation

harishp8889
Copy link
Collaborator

@harishp8889 harishp8889 commented Jan 13, 2025 •
edited
Loading

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Added secret inheritance for release action
Tested against fork: https://github.com/harishp8889/test-gofsutil-automation/actions/runs/12724867954/job/35471506833

@harishp8889 harishp8889 self-assigned this Jan 13, 2025
@nitesh3108
Copy link
Collaborator

@harishp8889 UTs are failing, pls check

@harishp8889
Copy link
Collaborator Author

@harishp8889 UTs are failing, pls check

They are failing in main branch only and there is no new change is introduced in this PR with respect to UT/functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

Assignees

@harishp8889 harishp8889

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishp8889 @nitesh3108 @chimanjain @suryagupta4