Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logus for default logger and add windows support #154

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

doriac11
Copy link
Collaborator

Description

  • Add //go:build !windows in the drv_cfg.go so we can compile on windows.
  • Remove references to /sirupsen/logrus for logging since it is no longer maintained. This was found during a blackduck scan. Instead use the go native logger: https://pkg.go.dev/log/[email protected]

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

api.go Outdated Show resolved Hide resolved
api.go Outdated Show resolved Hide resolved
@doriac11 doriac11 force-pushed the windows-logurs-fix branch 3 times, most recently from 7b3a49f to 63e1f6d Compare December 13, 2024 19:53
@doriac11 doriac11 merged commit a319320 into main Dec 13, 2024
5 of 6 checks passed
@doriac11 doriac11 deleted the windows-logurs-fix branch December 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants