Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Unit tests for Storage Pool #167

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Update Unit tests for Storage Pool #167

merged 3 commits into from
Dec 17, 2024

Conversation

harshitap26
Copy link
Contributor

Description

PR to update the code coverage for Storage Pool

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests are executing successfully.

tdawe
tdawe reviewed Dec 17, 2024
View reviewed changes
storagepool_test.go Outdated Show resolved Hide resolved
@harshitap26 harshitap26 requested a review from tdawe December 17, 2024 16:22
@harshitap26 harshitap26 requested a review from falfaroc December 17, 2024 16:43
@tdawe tdawe merged commit 396e78c into main Dec 17, 2024
5 of 6 checks passed
@tdawe tdawe deleted the usr/harshitap26/storagepool-unit-test branch December 17, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdawe tdawe tdawe approved these changes

@lukeatdell lukeatdell lukeatdell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy ashleyvjoy is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell rishabhatdell is a code owner

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1 sakshi-garg1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@falfaroc falfaroc Awaiting requested review from falfaroc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshitap26 @tdawe @lukeatdell