Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GET specific Resource Credential Model #179

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

doriac11
Copy link
Collaborator

Description

  • GET Resource Credential by id was not using the correct model which caused an empty model with nil values to be return instead of the full object.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
  • Integration Test

@doriac11 doriac11 force-pushed the resource-credential-get-model-fix branch from 1cf8050 to e49f97a Compare January 23, 2025 14:18
@doriac11 doriac11 merged commit 2463c98 into main Jan 24, 2025
6 checks passed
@doriac11 doriac11 deleted the resource-credential-get-model-fix branch January 24, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants