Modifiable values consistent across drivers (#583)

* made values.yaml consistent across drivers * fixed review comments * fixed new review comments
dell · Dec 19, 2024 · 178bd05 · 178bd05
1 parent 8d5e936
commit 178bd05
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 26 deletions.
diff --git a/charts/csi-isilon/values.yaml b/charts/csi-isilon/values.yaml
@@ -34,8 +34,8 @@ images:
 
 # CSI driver log level
 # Allowed values: "error", "warn"/"warning", "info", "debug"
-# Default value: "debug"
-logLevel: "debug"
+# Default value: "info"
+logLevel: "info"
 
 # certSecretCount: Represents number of certificate secrets, which user is going to create for
 # ssl authentication. (isilon-cert-0..isilon-cert-n)
@@ -118,8 +118,9 @@ controller:
 
   # volumeNamePrefix: Prefix of PersistentVolume names created
   # Allowed values: string
-  # Default value: None
-  volumeNamePrefix: k8s
+  # Default value: csivol
+  # Examples: "k8s", "app1"
+  volumeNamePrefix: csivol
 
   # leaderElection: configure leader election parameters
   leaderElection:
@@ -168,8 +169,9 @@ controller:
 
     # snapNamePrefix: Prefix to apply to the names of a created snapshots
     # Allowed values: string
-    # Default value: None
-    snapNamePrefix: snapshot
+    # Default value: csi-snap
+    # Examples: "snap", "snapshot"
+    snapNamePrefix: csi-snap
 
   resizer:
     # enabled: Enable/Disable volume expansion feature

diff --git a/charts/csi-powermax/values.yaml b/charts/csi-powermax/values.yaml
@@ -2,8 +2,8 @@
 global:
   # CSI driver log level
   # Allowed values: "error", "warn"/"warning", "info", "debug"
-  # Default value: "debug"
-  logLevel: "debug"
+  # Default value: "info"
+  logLevel: "info"
 
   # CSI driver log format
   # Allowed values: "TEXT" or "JSON"
@@ -52,7 +52,7 @@ global:
   managementServers:
     - endpoint: https://primary-1.unisphe.re:8443
       credentialsSecret: primary-1-secret
-      skipCertificateValidation: false
+      skipCertificateValidation: true
       certSecret: primary-cert
       limits:
         maxActiveRead: 5
@@ -61,7 +61,7 @@ global:
         maxOutStandingWrite: 50
     - endpoint: https://backup-1.unisphe.re:8443
       credentialsSecret: backup-1-secret
-      skipCertificateValidation: false
+      skipCertificateValidation: true
 #    - endpoint: https://primary-2.unisphe.re:8443
 #      credentialsSecret: primary-2-secret
 #      skipCertificateValidation: true
@@ -171,9 +171,9 @@ controller:
 
   # volumeNamePrefix: Define a prefix that is prepended to volumes.
   # THIS MUST BE ALL LOWER CASE.
-  # Default value: None
+  # Default value: csivol
   # Examples: "volumes", "vol"
-  volumeNamePrefix: pmax
+  volumeNamePrefix: csivol
 
   snapshot:
     # enabled: Enable/Disable volume snapshot feature
@@ -184,9 +184,9 @@ controller:
     enabled: true
     # snapNamePrefix: Define a prefix that is prepended to snapshots.
     # THIS MUST BE ALL LOWER CASE.
-    # Default value: None
+    # Default value: csi-snap
     # Examples: "snap", "snapshot"
-    snapNamePrefix: pmsn
+    snapNamePrefix: csi-snap
 
   resizer:
     # enabled: Enable/Disable volume expansion feature

diff --git a/charts/csi-powerstore/values.yaml b/charts/csi-powerstore/values.yaml
@@ -121,7 +121,8 @@ controller:
 
   # volumeNamePrefix: defines a string prepended to each volume created by the CSI driver.
   # Allowed values: string
-  # Default value: None
+  # Default value: csivol
+  # Examples: "k8s", "app1"
   volumeNamePrefix: csivol
 
   # vgsnapshot: allows to configure volume-group-snapshot
@@ -146,8 +147,9 @@ controller:
 
     # snapNamePrefix: Prefix to apply to the names of a created snapshots
     # Allowed values: string
-    # Default value: None
-    snapNamePrefix: csisnap
+    # Default value: csi-snap
+    # Examples: "snap", "snapshot"
+    snapNamePrefix: csi-snap
   # resizer: allows to enable/disable resizer feature
   resizer:
     # enabled: Enable/Disable volume expansion feature
@@ -305,8 +307,8 @@ connection:
 
 # CSI driver log level
 # Allowed values: "error", "warn"/"warning", "info", "debug", "error"
-# Default value: "debug"
-logLevel: "debug"
+# Default value: "info"
+logLevel: "info"
 
 # CSI driver log format
 # Allowed values: "TEXT" or "JSON"

diff --git a/charts/csi-unity/values.yaml b/charts/csi-unity/values.yaml
@@ -52,7 +52,7 @@ allowedNetworks:
 # IfNotPresent: Only pull the image if it does not already exist on the node.
 # Never: Never pull the image.
 # Default value: IfNotPresent
-imagePullPolicy: Always
+imagePullPolicy: IfNotPresent
 
 # Specify kubelet config dir path.
 # Ensure that the config.yaml file is present at this path.
@@ -80,7 +80,8 @@ controller:
 
   # volumeNamePrefix: Prefix of PersistentVolume names created
   # Allowed values: string
-  # Default value: None
+  # Default value: csivol
+  # Examples: "k8s", "app1"
   volumeNamePrefix: csivol
 
   snapshot:
@@ -93,7 +94,8 @@ controller:
 
     # snapNamePrefix: Prefix to apply to the names of a created snapshots
     # Allowed values: string
-    # Default value: None
+    # Default value: csi-snap
+    # Examples: "snap", "snapshot"
     snapNamePrefix: csi-snap
 
   resizer:

diff --git a/charts/csi-vxflexos/values.yaml b/charts/csi-vxflexos/values.yaml
@@ -44,8 +44,8 @@ certSecretCount: 0
 
 # CSI driver log level
 # Allowed values: "error", "warn"/"warning", "info", "debug"
-# Default value: "debug"
-logLevel: "debug"
+# Default value: "info"
+logLevel: "info"
 
 # CSI driver log format
 # Allowed values: "TEXT" or "JSON"
@@ -161,9 +161,9 @@ controller:
     interval: 60s
 
   # volumeNamePrefix- defines a string prepended to each volume created by the CSI driver.
-  # Default value: none
+  # Default value: csivol
   # Examples: "k8s", "app1"
-  volumeNamePrefix: k8s
+  volumeNamePrefix: csivol
 
   # "controllerCount" defines the number of VxFlex controller pods to deploy
   # Allowed values: n, where n > 0