Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the password check for SDC #212

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Move the password check for SDC #212

merged 1 commit into from
Aug 22, 2024

Conversation

shekhar-j
Copy link
Collaborator

@shekhar-j shekhar-j commented Aug 13, 2024

Description

Value of the parameter, check in validator block fails if parameter is passed as variable eg. var.user. Variable value is not available so it is empty or null.
Updated package path logic to work on Windows too.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@terraform-providers-svc
Copy link
Collaborator

Can one of the admins verify this patch?

doriac11
doriac11 previously approved these changes Aug 13, 2024
nikitajoshi1
nikitajoshi1 previously approved these changes Aug 13, 2024
doriac11
doriac11 previously approved these changes Aug 14, 2024
nikitajoshi1
nikitajoshi1 previously approved these changes Aug 14, 2024
@shekhar-j shekhar-j self-assigned this Aug 19, 2024
@shekhar-j
Copy link
Collaborator Author

run e2e test

1 similar comment
@shekhar-j
Copy link
Collaborator Author

run e2e test

nikitajoshi1
nikitajoshi1 previously approved these changes Aug 21, 2024
@shekhar-j shekhar-j merged commit a70d9f7 into main Aug 22, 2024
5 checks passed
@shekhar-j shekhar-j deleted the sdcHostWin branch August 22, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants