Grids - rectangle grid #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dellisd any updates here about this PR? |
dellisd
approved these changes
Feb 12, 2024
turf/src/commonTest/kotlin/io/github/dellisd/spatialk/turf/GridsTest.kt
Outdated
Show resolved
Hide resolved
turf/src/commonMain/kotlin/io/github/dellisd/spatialk/turf/Grids.kt
Outdated
Show resolved
Hide resolved
I checked the setting of my fork and I am using the default. The actions permissions are set to |
auto-merge was automatically disabled
February 15, 2024 21:01
Head branch was pushed to by a user without write access
|
OK, I guess now it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported the JS turf rectangle grid function. As base I used the turf/master implementation. The behaviour of rectangel grid algorithm in the latest stable turf.js release 6.5.0 is different from 7.0.0-alpha2. For further intformation see issue and fix
of the turf repo.
Also visually I confirmed the output [here]
