Add support for GeoJSON foreign members #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elcolto
reviewed
May 7, 2024
| /** | ||
| * A GeoJSON object represents a [Geometry], [Feature], or [collection of Features][FeatureCollection]. | ||
| * | ||
| * @property bbox An optional bounding box used to represent the limits of the object's geometry. | ||
| */ | ||
| interface GeoJson { | ||
| val bbox: BoundingBox? | ||
| val foreignMembers: MutableMap<String, JsonElement> |
There was a problem hiding this comment.
As this is always be defined by a backing field in the implementations, this property should be an immutable Map
Or is it desired to be modified after creation? Seems strange
There was a problem hiding this comment.
Yes, it does not make much sense right now. I copied this MutableMap approach from the Feature.properties, but it makes more sense in there since it has mutation methods for it. Should I change foreignMembers to be immutable everywhere?
There was a problem hiding this comment.
for public APIs I would recommend this 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements #128